Fixed reconciliation conditions#508
Fixed reconciliation conditions#508openshift-merge-bot[bot] merged 2 commits intovalidatedpatterns:mainfrom
Conversation
- when syncPolicy changes - when order of helm parameters changes - when order of helm valueFiles changes
|
Hi @sector2000. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| } | ||
| if (goal == nil) != (actual == nil) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Shall we check for SelfHeal and AllowEmpty, while we're at it?
|
thanks! |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari, sector2000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
openshift-merge-bot
bot
merged commit 34cf002
into
validatedpatterns:main
2 participants
Fixed reconciliation conditions:
Fixes #506
Fixes #507